Skip to content

Fix: Sass Slash as Division #243 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2021
Merged

Fix: Sass Slash as Division #243 #264

merged 1 commit into from
Oct 16, 2021

Conversation

@meirroth
Copy link

@meirroth meirroth commented Aug 24, 2021 •
edited
Loading

Description

Fixed the deprecated warning: Using / for division is deprecated and will be removed in Dart Sass 2.0.0
Followed the documentation here: https://sass-lang.com/documentation/breaking-changes/slash-div

Related Issue

Fixes #243

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    Only one test failed which has nothing to do with the changes this PR made.

@meirroth meirroth marked this pull request as ready for review August 24, 2021 23:26
dmalson-zaelab
dmalson-zaelab approved these changes Aug 24, 2021
View reviewed changes
Copy link

@dmalson-zaelab dmalson-zaelab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have write access, but I can confirm this is what fixed it when I tested on my local. :)

@stale
Copy link

stale bot commented Oct 1, 2021

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale Issue was not updated for some time and may be closed in the future label Oct 1, 2021
@Maronato Maronato merged commit 193c4b7 into Maronato:master Oct 16, 2021
@Maronato Maronato mentioned this pull request Oct 16, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maronato Maronato Maronato approved these changes

+1 more reviewer

@dmalson-zaelab dmalson-zaelab dmalson-zaelab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale Issue was not updated for some time and may be closed in the future

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Getting deprecated warning: Using / for division is deprecated and will be removed in Dart Sass 2.0.0

3 participants

@meirroth @Maronato @dmalson-zaelab